Re: [dev] svmidi - a simple virtual midi keyboard (WIP)

From: Henrique N. Lengler <henriqueleng_AT_openmailbox.org>
Date: Wed, 6 Apr 2016 23:50:52 -0300

On Thu, Apr 07, 2016 at 03:26:09AM +0200, Johnny Oskarsson wrote:
> Hi,
>
> I see now that 135da56cc and a338e9611 introduced an `undefined reference
> to midisend' when using ALSA. (since I was using a macro for that function,
> which became redundant with commit 135da56cc and removed in a338e9611)

Sorry I forgot it on alsa.c. :p

> Furthermore, I have also attached my patch for a 'clean build' on Linux
> (glibc). For some reason _POSIX_C_SOURCE needs to be defined in order for
> getopt(3) to be included from unistd.h. A few typedefs were not defined
> before being used, and as mentioned earlier, u_char was not defined at
> all on my system.
> Also, "util.h" does not seem to be part of the repository, but I
> can't find any missing functionality without it.
>
> I have attached both patches.

Thank you again, so I decided to let unsigned char as it is to avoid confusion,
since my BSD system already have a u_char.
So to avoid ambiguity, by now, unsigned char will be just unsigned char, and I
removed u_char from the code.

--
Henrique N. Lengler
Received on Thu Apr 07 2016 - 04:50:52 CEST

This archive was generated by hypermail 2.3.0 : Thu Apr 07 2016 - 05:00:14 CEST