Re: [dev] [slock] PAM support

From: Eric Pruitt <eric.pruitt_AT_gmail.com>
Date: Mon, 16 May 2016 11:54:04 -0700

On Mon, May 16, 2016 at 11:47:38AM -0700, Eric Pruitt wrote:
> On Mon, May 16, 2016 at 08:07:54PM +0200, Jan Christoph Ebersbach wrote:
> > I guess this issue can still happen. I didn't remove most of the getpw*
> > code in order to keep the patch small. I'm using sssd and so the getpw
> > calls still work. The only issue is that the password hash can't be
> > retrieved. This problem I solved with this patch by passing everything
> > through PAM.
>
> On the system I'm using that relies on PAM, my account doesn't have an
> entry in the local /etc/passwd file. Disabling getpw and related bits
> makes the patch work for me.

I have a suggestion -- I think you should add another color option to
the configuration. Since PAM configurations typically enforce a delay
before you can reauthenticate after an incorrect password is entered, it
would be nice if there was another color to indicate that slock is
waiting for the PAM functions to return.

Eric
Received on Mon May 16 2016 - 20:54:04 CEST