Re: [dev] [st] bitmap font and chscale 1< line drawing bug

From: <lemon_AT_bitmessage.ch>
Date: Wed, 7 Sep 2016 21:20:39 -0700

On Wed, Sep 07, 2016 at 06:02:53PM -0700, Eric Pruitt wrote:
> On Wed, Sep 07, 2016 at 06:01:48PM -0700, Eric Pruitt wrote:
> > On Wed, Sep 07, 2016 at 05:51:49PM -0700, lemon_AT_bitmessage.ch wrote:
> > > After moving to st-0.7, I am experiencing a bug with line drawing. When
> > > using a bitmap font (eg terminus) and a chscale=1.2 in config.h, every
> > > vertical line has gaps in it (ex tree or tmux). This persists for different
> > > bitmap fonts
> > > but goes away when chscale is set to 1.0.
> >
> > Did this not happen before st-0.7? I implemented the ch* factors in a
> > simple way just to control the invisible bounding boxes for each
> > character, and they don't scale the font itself; the behavior you're
> > seeing is working as intended, and it's also what I observed when I was
> > testing the feature and experimented with different scaling factors. I
> > have noticed that on some operating systems, even using the exact same
> > st compile options and fonts, I get slightly different results -- on my
> > work computer, there are 1-pixel gaps between vertical lines (not pipe
> > but "│"), but at home, the gaps aren't there. I don't find this annoying
> > enough to invest any effort into figuring out why that happens despite
> > both computers being Debian-based.
>
> Also, if this doesn't happen in earlier versions, you could use
> git-bisect (https://git-scm.com/docs/git-bisect) to figure out which
> commit introduced the problem.
>
> Eric
 
This did not happen in st-0.6. Okay I'll check out git-bisect and see if
I can figure it out. I'll submit a patch or pull request if I find a
solution. Thanks.

lemon
Received on Thu Sep 08 2016 - 06:20:39 CEST

This archive was generated by hypermail 2.3.0 : Thu Sep 08 2016 - 06:24:12 CEST