Re: [dev] [ST] scroll patch build failure [SOLVED]

From: Nick Warne <nick_AT_linicks.net>
Date: Fri, 23 Sep 2016 17:23:26 +0100

On Fri, 23 Sep 2016 17:09:36 +0100
Nick Warne <nick_AT_linicks.net> wrote:

> I am not getting much luck here (do _I_ suck?) :(
>
> dwm and st work great so far and I am well impressed and happy; but
> any patches I apply either fail:
>
> http://lists.suckless.org/dev/1609/30448.html
>
> (I have since tried git versions, and it fails to build - but more
> later, that is on the back-burner for a mo)
>
> ...or get build errors:
>
> apply the patch to st for scrollback. Latest git
> and latest diff. Patches fine.
>
> > make
>
> st.c:337:12: error: ‘histsize’ undeclared here (not in a function)
> Line hist[histsize]; /* history buffer */
>
> I have read through the code several times for about an hour, but
> can't work out what is going on?
>
> Ideas?

Talking to myself and going mad, I sorted it.

GCC being pedantic:

#CFLAGS += -g -std=c99 -pedantic -Wall -Wvariadic-macros -Os ${INCS}
${CPPFLAGS} CFLAGS += -g -std=c99 -Wall -Wvariadic-macros -Os ${INCS}
${CPPFLAGS}

All built and works great!

Thanks,

Nick
-- 
"Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"
Received on Fri Sep 23 2016 - 18:23:26 CEST

This archive was generated by hypermail 2.3.0 : Fri Sep 23 2016 - 18:36:05 CEST