Re: [dev] [PATCH 2/2] slstatus: determine the number of cpu's in runtime

From: Kurt Van Dijck <dev.kurt_AT_vandijck-laurijssen.be>
Date: Sat, 16 Sep 2017 19:26:54 +0200

> Hi,
>
> >Why do we need to get the number of cpus in runtime? It's a static value,
> >which in worst case changes after a reboot when disabling hyperthreading.
> >
> >Also, using ncpu for more than one thing (first it's flag, then it's a
> >number) is a really bad idea.
> >
> >I don't think this should be merged, neither the whole 100% vs per-core
> >thing: I think that it gives little to no information, and it doesn't
> >seems to play nice with multi-threaded CPUs (in a 2:2 setup, does having
> >over 200% means that the cpu is over-the-top? Maybe it's the same core, so
> >it can handle more load, but maybe not, so, what info did it gave to me?)
>
> I totally agree to that.

Well, I just replied to this set of alternative facts. My comment still
applies.

> I will neither merge this patch, nor the 100% thing.
> Thank you very much for your work, Kurt,

You should understand that I did this primarily to serve myself :-)

> but I think that these two
> patches do not fit well into slstatus.

Well, opinions may differ :-)

Kind regards,
Kurt
Received on Sat Sep 16 2017 - 19:26:54 CEST