Re: [dev] [dwm] Crash (possibly related to ru_bottomstack?) no actually problem is attachabove

From: TRS-80 <suckless.trs-80_AT_isnotmyreal.name>
Date: Tue, 25 Feb 2020 17:50:13 -0500

OK, after yet more testing, I am pretty sure I have vindicated
ru_bottomstack. I now think the culprit is actually attachabove, based
on the following extended testing:

       |---+---------------------------------------+--------+---------|
       | # | patch(es) | result | Note |
       |---+---------------------------------------+--------+---------|
       | 1 | dwm-ru_gaps-6.2.diff | OK | |
       |---+---------------------------------------+--------+---------|
       | 2 | dwm-ru_bottomstack-6.2.diff | 1 | |
       |---+---------------------------------------+--------+---------|
       | 3 | dwm-ru_bottomstack-6.2.diff | 2 | mistake |
       | | dwm-ru_gaps-6.2.diff | | |
       |---+---------------------------------------+--------+---------|
       | 4 | dwm-fullgaps-6.2.diff | crash | |
       | | dwm-bottomstack-20160719-56a31dc.diff | | |
       | | dwm-attachabove-20180126-db22360.diff | | |
       |---+---------------------------------------+--------+---------|
       | 5 | dwm-ru_gaps-6.2.diff | OK | |
       | | dwm-ru_bottomstack-6.2.diff | | |
       |---+---------------------------------------+--------+---------|
       | 6 | dwm-fullgaps-6.2.diff | OK! | |
       | | dwm-bottomstack-20160719-56a31dc.diff | | |
       |---+---------------------------------------+--------+---------|
       | 7 | dwm-attachabove-20180126-db22360.diff | crash | |
       |---+---------------------------------------+--------+---------|

I would also like to note a mistake I made earlier. On test #3, I
previously reported result #2:

On 2020-02-25 14:46, TRS-80 wrote:
>
> 2. some errors on make:
> #+BEGIN_SRC bash
> rm -f dwm drw.o dwm.o util.o dwm-6.2.tar.gz
> dwm build options:
> CFLAGS = -std=c99 -pedantic -Wall -Wno-deprecated-declarations
> -Os -I/usr/X11R6/include -I/usr/include/freetype2 -D_DEFAULT_SOURCE
> -D_BSD_SOURCE -D_POSIX_C_SOURCE=2 -DVERSION="6.2" -DXINERAMA
> LDFLAGS = -L/usr/X11R6/lib -lX11 -lXinerama -lfontconfig -lXft
> CC = cc
> cc -c -std=c99 -pedantic -Wall -Wno-deprecated-declarations -Os
> -I/usr/X11R6/include -I/usr/include/freetype2 -D_DEFAULT_SOURCE
> -D_BSD_SOURCE -D_POSIX_C_SOURCE=2 -DVERSION=\"6.2\" -DXINERAMA drw.c
> cc -c -std=c99 -pedantic -Wall -Wno-deprecated-declarations -Os
> -I/usr/X11R6/include -I/usr/include/freetype2 -D_DEFAULT_SOURCE
> -D_BSD_SOURCE -D_POSIX_C_SOURCE=2 -DVERSION=\"6.2\" -DXINERAMA dwm.c
> dwm.c: In function ‘createmon’:
> dwm.c:645:13: error: ‘gappx’ undeclared (first use in this
> function)
> m->gappx = gappx;
> ^~~~~
> dwm.c:645:13: note: each undeclared identifier is reported only
> once for each function it appears in
> At top level:
> dwm.c:1513:1: warning: ‘setgaps’ defined but not used
> [-Wunused-function]
> setgaps(const Arg *arg)
> ^~~~~~~
> make: *** [Makefile:18: dwm.o] Error 1
>
> #+END_SRC
>

In this case, I actually simply forgot to copy config.def.h -> config.h
before compiling.... :/

Testing again with doing that (see test #5, above) and everything works
correctly.

FWIW, attachabove never really worked for me, now I think I understand
why.

To reproduce, just include attachabove and try and pull any Client from
Stack to Master, and dwm will crash.

I guess for now I just avoid that patch.

Cheers!

TRS-80
Received on Tue Feb 25 2020 - 23:50:13 CET