Re: [dev] [dwm] possible regression in 8806b6e

From: Jochen Sprickerhof <dwm_AT_jochen.sprickerhof.de>
Date: Mon, 25 Apr 2022 18:29:20 +0200

* Hiltjo Posthuma <hiltjo_AT_codemadness.org> [2022-04-25 18:13]:
>On Mon, Apr 25, 2022 at 04:00:21PM +0200, Jochen Sprickerhof wrote:
>> Hi Chris,
>>
>> * Chris Down <chris_AT_chrisdown.name> [2022-04-25 14:47]:
>> > I'm still unable to reproduce the issue, but I am curious, does this fix
>> > things? :-)
>> >
>> > diff --git a/dwm.c b/dwm.c
>> > index 0fc328a..f2a10c0 100644
>> > --- a/dwm.c
>> > +++ b/dwm.c
>> > _AT_@ -1061,6 +1061,7 @@ manage(Window w, XWindowAttributes *wa)
>> > XSetWindowBorder(dpy, w, scheme[SchemeNorm][ColBorder].pixel);
>> > configure(c); /* propagates border_width, if size doesn't change */
>> > updatewindowtype(c);
>> > + updatesizehints(c);
>> > updatewmhints(c);
>> > XSelectInput(dpy, w, EnterWindowMask|FocusChangeMask|PropertyChangeMask|StructureNotifyMask);
>> > grabbuttons(c, 0);
>> >
>> > My guess is that the pinentry that you're using relies on early
>> > c->isfixed logic, whereas the one Sebastian and I are using relies on
>> > WM_TRANSIENT_FOR, so the issue I reported and the one you reported have
>> > different causes, despite having different symptoms.
>> >
>> > If this fixes it, please let me know and I'll send it as a proper patch.
>>
>> This fixes a similar issue for me.
>>
>> Thanks!
>>
>> Jochen
>
>Whats the similar issue exactly?

The splash screen of Jameica https://www.willuhn.de/products/jameica/
(Java platform) has a floating window without 8806b6e resp. the change
above. (I don't really care for the splash screen, only noticed the
behavior change.)

>Does this issue also happen when bisecting the
>same commit (so its a also regression)?

Yes. I also tested bece862 but it made no difference.

Cheers Jochen

Received on Mon Apr 25 2022 - 18:29:20 CEST

This archive was generated by hypermail 2.3.0 : Mon Apr 25 2022 - 18:36:07 CEST