Re: [dwm] sel without clients?

From: Anselm R. Garbe <>
Date: Fri, 11 Aug 2006 08:53:15 +0200

On Thu, Aug 10, 2006 at 04:13:19PM -0400, Ross Mohn wrote:
> On Thu, 2006-08-10 at 13:28 -0400, Ross Mohn wrote:
> > At the beginning of the zoom() function, you return if sel is NULL. But
> > then later on you check to see if clients is NULL:
> >
> > if(clients)
> > clients->prev = sel;
> >
> > How would it be possible for clients to be NULL if sel has a value?
> Follow up question: Would you be willing to pull the pop code out of
> zoom() and make it its own function? I think this would be useful for
> customizations.

Actually pop would consist of atomic detach and attach
functions. A single pop() which is called in one place is no
good idea in my eyes. I actually only implement a function if it
is called at least in two places. The attach/detach functions
would be called in two places each (attach in manage and zoom,
detach in unmanage and zoom). However I decided against this
because those functions are 4 liners actually and the code in
zoom can be optmized somewhat without calling
detach(c);attach(c); for pop(c) in a row.

Thus, No.


 Anselm R. Garbe  ><><  ><><  GPG key: 0D73F361
Received on Fri Aug 11 2006 - 08:53:15 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 14:30:05 UTC