Re: [dwm] broken pipes

From: Anselm R. Garbe <>
Date: Sat, 25 Nov 2006 19:18:45 +0100

Hi Manuel,

On Sat, Nov 25, 2006 at 08:17:59AM +0100, Manuel Badzong wrote:
> I mainly changed 5 little things in the main event loop:
> + I reordered the select statement which seemed a little cluttered (no
> offense).
> + I replaced fgets with read (I hate this FILE* crap). If for some
> reason you prefer ANSI C over UNIX IO use feof() to catch EOF.
> + On error or EOF the appropriate message is written to the status bar
> indicating exactly what happened (e.g. EOF when redirected by [xkg]dm).
> + I removed the double checking of readin and FD_ISSET on stdin (as
> FD_ISSET is tested anyway and properly set by select).
> + Finally I added a FD_ISSET check for xfd (I didn't read the whole code
> but I think it's appropriate because changing the status bar doesn't
> require procevent [is it?])

I'm going to apply your patch on monday to the central repository.


 Anselm R. Garbe >< >< GPG key: 0D73F361
Received on Sat Nov 25 2006 - 19:18:45 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 14:32:45 UTC