Re: [dwm] resize() is side effect free?

On Fri, Feb 16, 2007 at 02:13:53PM +0100, Anselm R. Garbe wrote:
> On Thu, Feb 15, 2007 at 08:07:54PM +0000, David Tweed wrote:
> > Hi Anselm, I don't really understand X so I'm just trying to
> > check: if I've got a tiled client and within dotile() its got
> > the same x,y,w & h as the last time through dotile(), it seems
> > like it's ok to avoid calling the reize() on it. At least, it
> > doesn't appear to cause any problems, but I'm just checking
> > there's not a subtle X point I'm missing.
> >
> > (I'm heavily using applications that seem to send
> > configurerequest's when you do things like use a dragbox in
> > the window, so if I don't add this extra test in dotile()
> > things I get a flickering effect from the other "slow redraw"
> > clients. With this "don't resize if unnecessary" check I can't
> > see the flickering anymore.)
>
> Hah, yes the only reason for the unnecessary resizals is
> simplicity, but I agree that we should avoid this ;) Actually I
> consider changing resize() instead to do the check...

I pushed a change which only calls XResize... when necessary.

Regards,

-- 
 Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361