Re: [dwm] Reloading running dwm - reload patch

Christian Garbs --> dwm (2007-03-22 23:29:37 +0100):
> I like the SIGUSR1 approach (which, btw, currently does not work for
> me at all,

See the first comment in the message below, I bet that's the source
of your problem...

HTH, Jukka

----- Forwarded message from Jukka Salmi -----

From: Jukka Salmi
Subject: Re: [dwm] Reloading running dwm - reload patch
Date: Wed, 21 Mar 2007 13:17:07 +0100
To: dfenze_AT_gmail.com

Hi,

dfenze_AT_gmail.com wrote:
> I created patch for reloading dwm with signal USR1.

thanks!

Some comments about it:

- In doreload() I'd call execvp() instead of execve(), otherwise
  reloading will not work if argv[0] is a relative pathname. Furthermore
  this would save you from having to pass `environ'.

- In cleanup(), instead of removing the call to close() I'd prepend
  "if (!reload)" to it.

- Both sigusr1() and doreload() should probably be static.

- The string passed with eprint() should be terminated by a newline ;-)

Regards, Jukka

----- End forwarded message -----

-- 
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~