Re: [dwm] Urgency hook?

On Dec 19, 2007 2:45 PM, Jeremy O'Brien <obrien654j_AT_gmail.com> wrote:

> On Tue, Dec 18, 2007 at 10:35:58PM -0800, Amit Uttamchandani wrote:
> > On Wed, 19 Dec 2007 00:59:56 -0500
> > "Jeremy O'Brien" <obrien654j_AT_gmail.com> wrote:
> >
> > > On Tue, Dec 18, 2007 at 09:32:11PM -0800, Ryan Zheng wrote:
> > > > Hi all,
> > > >
> > > > I've created a patch that handles the urgent hint for dwm 4.5. It
> > > > changes the color of the square. It's probably buggy, but it seems
> to
> > > > work.
> > > >
> > > > Ryan
> > > >
> > >
> > > Wow. A few minor tweaks and it works with 4.7. And it seems to work
> > > perfectly from here :) Thank you for this...
> > >
> >
> > Do you mind posting the modified patch for 4.7? ;)
> >
> > Thanks!
> >
>
> Hehe. My first patch ever! I emulated the author's style of modifying
> the config.h file over the config.def.h. The changes are easily spotted
> however. Here goes!
>

Wow, nice job for a first patch!
However, I really think you should use config.def.h for config changes. You
don't want a patch application to fail because somebody has a different
colorscheme in his config :)

I am using the patch right now... Since this is an integral wm feature and
not a wm-ui enhancement, I really think this is a good candidate for
inclusion in mainline dwm.

Ritesh

> --
> Jeremy O'Brien aka neutral_insomniac
> GPG key: 0xB1140FDB http://pohl.ececs.uc.edu/~jeremy/jeremy.asc<http://pohl.ececs.uc.edu/%7Ejeremy/jeremy.asc>
> Linux ambelina 2.6.22.9 #1 Zilog(R) Z80
> processor 4MHz GNU/Linux
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFHaXTuJUoJkLEUD9sRAphzAKCh8RdcLazWvm7CrpG2CL1+XTFtGACfWW/F
> xnfEV0MMfrMhRjQeOMPe6EY=
> =lMzj
> -----END PGP SIGNATURE-----
>
>
Received on Thu Dec 20 2007 - 00:14:19 UTC