Re: [dwm] dmenu, slock patches; slock DPMS crash

From: Peter Hartlich <sgkkr_AT_hartlich.com>
Date: Tue, 8 Apr 2008 00:22:13 +0200

Hi Jukka,

> I'd prefer
>
> exe=`dmenu_path | dmenu ${1+"$@"}` && exec $exe

Agreed.

>> uptodate() {
>> - test ! -f $CACHE && return 1
>> + test -f "$CACHE" &&
>> for dir in $PATH
>> do
>> - test $dir -nt $CACHE && return 1
>> + test ! $dir -nt "$CACHE" || return 1
>> done
>> - return 0
>> }
 
> Why? This is equivalent...

Besides the quoting, one and a half lines less. :)

> Not all sort(1)s have a -u option.

Whoops, sorry then. I had checked SuS, heirloom toolchest, the autoconf
portability manual and DJB's portability notes and none of them mentioned
a missing -u option.

Regards,
Peter
Received on Tue Apr 08 2008 - 00:22:39 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 15:31:56 UTC