Re: [dwm] [patch] minor cleanups

2008/8/10 Szabolcs Nagy <nszabolcs_AT_gmail.com>:
> On 8/4/08, Johannes Hofmann <Johannes.Hofmann_AT_gmx.de> wrote:
>> attached are two minor cleanups. The first simplifies grabkeys()
>> similar to grabbuttons().
>
> i've just realized that there is a problem with the patch: numlockmask
> is modified but modifiers isn't
>
> void
> grabkeys(void) {
> unsigned int i, j;
> unsigned int modifiers[] = { 0, LockMask, numlockmask, numlockmask|LockMask };

Hmm, why is this a problem since modifiers is not static and
reinitialized freshly in each grabkeys() call?

Kind regards,
--Anselm
Received on Mon Aug 18 2008 - 08:44:39 UTC