[dwm] 5456239bb8ad commit braked cyrillic

From: Maxim Vuets <maxim.vuets_AT_gmail.com>
Date: Sun, 24 Aug 2008 21:48:54 +0300

Hi!

I've found that 5456239bb8ad braked cyrillic titles for me:
- if(!setlocale(LC_CTYPE, "") || !XSupportsLocale())
+ if(!XSupportsLocale())
                fprintf(stderr, "warning: no locale support\n");

Now non-latin characters are just skipped as if they are absant at all.
Anselm, why have you removed the setlocale() call?

setlocale man page says:

If locale is "", each part of the locale that should be modified is set
**according to the environment variables**.
...
On startup of the main program, the portable "C" locale is selected as
default. A program may be made **portable to all locales** by calling
setlocale(LC_ALL, "") after program initialization
...
LC_CTYPE
for regular expression matching, character classification, conver$B!>(B
sion, case-sensitive comparison, and **wide character functions**.

I believe that this commit should be backouted.

-- 
Hoc est simplicissimum!
maxim.vuets.name
Received on Sun Aug 24 2008 - 18:48:54 UTC

This archive was generated by hypermail 2.2.0 : Sun Aug 24 2008 - 19:00:04 UTC