Re: [dwm] 5456239bb8ad commit braked cyrillic

2008/8/24 Maxim Vuets <maxim.vuets_AT_gmail.com>:
> I've found that 5456239bb8ad braked cyrillic titles for me:
> - if(!setlocale(LC_CTYPE, "") || !XSupportsLocale())
> + if(!XSupportsLocale())
> fprintf(stderr, "warning: no locale support\n");
>
> Now non-latin characters are just skipped as if they are absant at all.
> Anselm, why have you removed the setlocale() call?
>
> setlocale man page says:
>
> If locale is "", each part of the locale that should be modified is set
> **according to the environment variables**.
> ...
> On startup of the main program, the portable "C" locale is selected as
> default. A program may be made **portable to all locales** by calling
> setlocale(LC_ALL, "") after program initialization
> ...
> LC_CTYPE
> for regular expression matching, character classification, conver$B!>(B
> sion, case-sensitive comparison, and **wide character functions**.
>
> I believe that this commit should be backouted.

Sorry, restored. I actually missed this subtle side-effect in
setlocale() when I removed it ;)

Kind regards,
--Anselm
Received on Mon Aug 25 2008 - 08:46:25 UTC