Re: [dwm] applyrules

Hi Filippo,

2008/8/27 Filippo Erik Negroni <f.e.negroni_AT_googlemail.com>:
> In applyrules(), the return value of XGetClassHint is not checked.

Agreed.

> ch is also initialised to {0}, which, I believe, is reduntant if
> XGetClassHint is successful.

Well, I think we should keep this and also the checks for res_class
and res_name, since it is not mandatory to set both or any of these
WM_CLASS properties. If seen some apps during the last 6 years of X
work, which are broken in this way.

> The global static variable dc is initialised to {0}, which is redundant,
> being a static.

Is this defined somewhere?

Kind regards,
--Anselm
Received on Fri Aug 29 2008 - 09:14:46 UTC