Re: [dwm] applyrules

Anselm R Garbe wrote:
> Hi Filippo,
>
> 2008/8/27 Filippo Erik Negroni <f.e.negroni_AT_googlemail.com>:
> > In applyrules(), the return value of XGetClassHint is not checked.
>
> Agreed.
>
> > ch is also initialised to {0}, which, I believe, is reduntant if
> > XGetClassHint is successful.
>
> Well, I think we should keep this and also the checks for res_class
> and res_name, since it is not mandatory to set both or any of these
> WM_CLASS properties. If seen some apps during the last 6 years of X
> work, which are broken in this way.
>
> > The global static variable dc is initialised to {0}, which is redundant,
> > being a static.
>
> Is this defined somewhere?

ISO/IEC 9899:TC2 page 126 (Section 6.7.8.8):
> - if it has a pointer type, is initialized to a null pointer;
 
> Kind regards,
> --Anselm

Regards
Matthias-Christian
Received on Fri Aug 29 2008 - 09:30:03 UTC