Re: [dwm] Border hater, border lover

2008/12/17 yy <yiyu.jgl_AT_gmail.com>:
> 2008/12/17 Anselm R Garbe <garbeam_AT_gmail.com>:
>> It's in. Please recheck if there are any issues. Otherwise I'm going
>> to release 5.4 tomorrow.
>>
>
> Two things (of not too much importance, anyway):
>
> 1. What about the applyrules modification discussed in
> http://lists.suckless.org/dwm/0812/7057.html ?
> 2. IMO the issingle variable name in adjustborder() should be changed,
> e.g. to hasborder.
>
> I will elaborate on #2: I'm using a modified monocle where the border
> is removed when the status bar is not visible, so that I have some
> kind of fullscreen layout (very useful for firefox video windows from
> some sites). When I have seen this new function I thought that it
> would perfectly fit in this function (maybe it could even go into
> main? I think it will be just one more line), but issingle doesn't
> make too much sense then.
>
> Anyway, as I told, nothing important...
>
>
> --
>
>
> - yiyus || JGL .
>

I have just realized it wouldn't need a single line of code to remove
the border in "fullscreen" layout (i.e.: monocle + !showbar). Inside
monocle, doesn't
        adjustborder(c, n == 1 || !showbar)
make sense to you?

Maybe you could also have a new define in config.h, so people can choose:
#define MONOCLEBORDER n == 1
#define MONOCLEBORDER n == 1 || !showbar
#define MONOCLEBORDER True
Anyway, having borders in monocle is probably a matter of taste, but
it is so easy adding your own layout that I doubt it is even a
matter...

PS: I will stop rambling now and will wait for tomorrow release. Good night!

-- 
- yiyus || JGL .