[hackers] [surf] Disabling WebKit deletion interface feature by default. || Alexander Sedov

From: <git_AT_suckless.org>
Date: Wed, 17 Apr 2013 19:28:10 +0200

commit d0309a1a226425c1b8086d7b20a6f4e3dcb06872
Author: Alexander Sedov <alex0player_AT_gmail.com>
Date: Fri Mar 15 20:32:13 2013 +0400

    Disabling WebKit deletion interface feature by default.
    Webkit has an amazing "feature" that shows black outline with cross
    around some randomly chosen text fields. Its only fucntion is to
    clear field. It's ugly and gets in the way when trying to actually
    ready what you've written, so here's a patch to disable it.
    Signed-off-by: Christoph Lohmann <20h_AT_r-36.net>

diff --git a/surf.c b/surf.c
index e325126..87116f9 100644
--- a/surf.c
+++ b/surf.c
_AT_@ -106,6 +106,8 @@ static gboolean decidedownload(WebKitWebView *v, WebKitWebFrame *f,
 static gboolean decidewindow(WebKitWebView *v, WebKitWebFrame *f,
                 WebKitNetworkRequest *r, WebKitWebNavigationAction *n,
                 WebKitWebPolicyDecision *p, Client *c);
+static gboolean deletion_interface(WebKitWebView *view,
+ WebKitDOMHTMLElement *arg1, Client *c);
 static void destroyclient(Client *c);
 static void destroywin(GtkWidget* w, Client *c);
 static void die(const char *errstr, ...);
_AT_@ -386,6 +388,12 @@ decidewindow(WebKitWebView *view, WebKitWebFrame *f, WebKitNetworkRequest *r,
         return FALSE;
+static gboolean
+deletion_interface(WebKitWebView *view,
+ WebKitDOMHTMLElement *arg1, Client *c) {
+ return FALSE;
 static void
 destroyclient(Client *c) {
         Client *p;
_AT_@ -715,6 +723,9 @@ newclient(void) {
                         G_CALLBACK(beforerequest), c);
+ g_signal_connect(G_OBJECT(c->view),
+ "should-show-delete-interface-for-element",
+ G_CALLBACK(deletion_interface), c);
         /* Scrolled Window */
         c->scroll = gtk_scrolled_window_new(NULL, NULL);
Received on Wed Apr 17 2013 - 19:28:10 CEST

This archive was generated by hypermail 2.3.0 : Wed Apr 17 2013 - 19:36:13 CEST