Re: [hackers] [st] Mouse buttons binding

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Sun, 28 Apr 2013 08:47:08 +0200

Greetings.

On Sun, 28 Apr 2013 08:47:08 +0200 Alexander Rezinsky <alexrez_AT_gmail.com> wrote:
> diff --git a/config.def.h b/config.def.h
> index b44fe17..a35aaa9 100644
> --- a/config.def.h
> +++ b/config.def.h
> _AT_@ -322,6 +322,19 @@ static Key key[] = {
> };
>
> /*
> + * Special mouse buttons
> + */
> +#define SCREEN_ESC "\001"
> +
> +static MouseB mouseb[] = {
> + { Button4, ShiftMask, SCREEN_ESC "\0331\025" },
> + { Button4, ControlMask, SCREEN_ESC "\033\002" },
> + { Button4, XK_ANY_MOD, SCREEN_ESC "\03320\025" },
> + { Button5, ShiftMask, SCREEN_ESC "\0331\004" },
> + { Button5, ControlMask, SCREEN_ESC "\033\006" },
> + { Button5, XK_ANY_MOD, SCREEN_ESC "\03320\004" },
> +};

Your patch is changing the current meaning of the mouse wheel up and
down. Where did you get that escape codes from and which application
does need such masked button events?

What’s SCREEN_ESC? Where did you get that value from? Why does it need
to be defined separately?

Why do you handle mouse shortcuts before mousereport? Then the applica‐
tion is meant to handle all mosue events. Is this needed in your case?


Sincerely,

Christoph Lohmann
Received on Sun Apr 28 2013 - 08:47:08 CEST

This archive was generated by hypermail 2.3.0 : Sun Apr 28 2013 - 09:00:12 CEST