[hackers] [st] Simplify a bit more tdeletechar and tinsertblank || Roberto E. Vargas Caballero

From: <git_AT_suckless.org>
Date: Fri, 25 Apr 2014 17:26:52 +0200

commit 6b7f63bac597ca03e18fe63ad522b4d1bded08d1
Author: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Fri Apr 25 17:24:12 2014 +0200

    Simplify a bit more tdeletechar and tinsertblank
    
    The large and repeated expression used in memmove to indirect
    the line can be simplified using a pointer, that makes more
    clear where begins and where ends the movement.

diff --git a/st.c b/st.c
index 263abaa..e468d73 100644
--- a/st.c
+++ b/st.c
_AT_@ -1587,30 +1587,32 @@ tclearregion(int x1, int y1, int x2, int y2) {
 void
 tdeletechar(int n) {
         int dst, src, size;
+ Glyph *line;
 
         LIMIT(n, 0, term.col - term.c.x);
 
         dst = term.c.x;
         src = term.c.x + n;
         size = term.col - src;
+ line = term.line[term.c.y];
 
- memmove(&term.line[term.c.y][dst], &term.line[term.c.y][src],
- size * sizeof(Glyph));
+ memmove(&line[dst], &line[src], size * sizeof(Glyph));
         tclearregion(term.col-n, term.c.y, term.col-1, term.c.y);
 }
 
 void
 tinsertblank(int n) {
         int dst, src, size;
+ Glyph *line;
 
         LIMIT(n, 0, term.col - term.c.x);
 
         dst = term.c.x + n;
         src = term.c.x;
         size = term.col - dst;
+ line = term.line[term.c.y];
 
- memmove(&term.line[term.c.y][dst], &term.line[term.c.y][src],
- size * sizeof(Glyph));
+ memmove(&line[dst], &line[src], size * sizeof(Glyph));
         tclearregion(src, term.c.y, dst - 1, term.c.y);
 }
 
Received on Fri Apr 25 2014 - 17:26:52 CEST