Re: [hackers] [sbase] [PATCH 1/2] join: get rid of strlen--fwrite barbarity

From: FRIGN <>
Date: Sat, 6 Jun 2015 22:19:11 +0200

On Sat, 6 Jun 2015 13:07:26 -0400
Wolfgang Corcoran-Mathe <> wrote:

Hey Wolfgang,

> This gets rid of a barbarous strlen()/fwrite() construct.

I have to admit, that it's not easy to decide which one is
On the one hand, I favor good data structures and having
the length at hand is a good thing.
On the other hand, join is completed feature-wise, so why
not just store the length on the heap locally in the function
and be done with it?

It's not barbarous at all.



Received on Sat Jun 06 2015 - 22:19:11 CEST

This archive was generated by hypermail 2.3.0 : Thu Jun 18 2015 - 17:36:24 CEST