Re: [hackers] [sbase] [PATCH 1/2] join: get rid of strlen--fwrite barbarity

From: Wolfgang Corcoran-Mathe <>
Date: Sat, 6 Jun 2015 19:36:01 -0400


Quoth FRIGN on Sat, Jun 06 2015 22:19 +0200:
> I have to admit, that it's not easy to decide which one is better.
> On the one hand, I favor good data structures and having the
> length at hand is a good thing.
> On the other hand, join is completed feature-wise, so why not
> just store the length on the heap locally in the function and be
> done with it?

The original is probably better, especially since the patched version
doesn't seem to be quicker. The length is only needed for that
fwrite() call, anyway; it seems best to keep single-purpose values
out of a heavily-used data structure.

Patch withdrawn! I'm sorry if it was a waste of time. I appreciate
your opinions on this.

Wolfgang Corcoran-Mathe
Received on Sun Jun 07 2015 - 01:36:01 CEST

This archive was generated by hypermail 2.3.0 : Thu Jun 18 2015 - 17:36:27 CEST