[hackers] Re: [dmenu] Use libsl/libdraw code and add Xft support

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Fri, 12 Jun 2015 11:42:32 +0200

On Mon, Jun 8, 2015 at 11:48 PM, Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:
> On Mon, Jun 8, 2015 at 11:05 PM, Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:
>> ... snip ...
>>
>

Some more thoughts: in drw.c these functions don't check if drw ==
NULL before use: drw_load_fonts, drw_font_xcreate.

We should probably not check these in drw.c and let the program using
drw error out at drw_create(). If an invalid context is passed it
should just crash. This would make spotting errors regarding drw.{c,h}
simpler aswell.

Kind regards,
Hiltjo
Received on Fri Jun 12 2015 - 11:42:32 CEST