Re: [hackers] Re: [dmenu] Use libsl/libdraw code and add Xft support

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Sat, 13 Jun 2015 10:51:26 +0100

On Fri, Jun 12, 2015 at 11:42:32AM +0200, Hiltjo Posthuma wrote:
> On Mon, Jun 8, 2015 at 11:48 PM, Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:
> > On Mon, Jun 8, 2015 at 11:05 PM, Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:
> >> ... snip ...
> >>
> >
>
> Some more thoughts: in drw.c these functions don't check if drw ==
> NULL before use: drw_load_fonts, drw_font_xcreate.
>
> We should probably not check these in drw.c and let the program using
> drw error out at drw_create(). If an invalid context is passed it
> should just crash. This would make spotting errors regarding drw.{c,h}
> simpler aswell.

Works well for me.

Anselm, can we merge this?
Received on Sat Jun 13 2015 - 11:51:26 CEST