Re: [hackers] [sbase] [PATCH] find

From: Evan Gates <evan.gates_AT_gmail.com>
Date: Mon, 15 Jun 2015 13:24:02 -0700

On Mon, Jun 15, 2015 at 12:27 PM, Wolfgang Corcoran-Mathe
<first.lord.of.teal_AT_gmail.com> wrote:
> emg,
>
> I noticed a few other things in get_ok_arg(), primarily that the fgets()
> flushing loop was causing find to hang mysteriously. Patch 2/3 should
> fix this, hopefully.

Should have said buf[strlen(buf) - 1] != '\n' in order to keep
reading until we got a full newline terminated line of input, not sure
how that got through. I prefer your solution as it doesn't run into
any of the '\0' problems.

> The isplus branch seems to work, based on limited testing.

Yep, it looks alright, the bug was specific to the array of pointers
to {} used in -ok and -exec \;
I had originally thought it was a bug relating to NULL termination for
execvp() when reading your mail (I finally have the code in front of
me, that's helpful).

> I've enjoyed reading your code, btw.

Thanks! Good to hear. Criticism, constructive or otherwise, is always welcome.
-emg
Received on Mon Jun 15 2015 - 22:24:02 CEST