Re: [hackers] [sbase] [PATCH 1/3] find: Fix unterminated array in -ok primary

From: Evan Gates <evan.gates_AT_gmail.com>
Date: Mon, 15 Jun 2015 13:51:00 -0700

On Mon, Jun 15, 2015 at 12:27 PM, Wolfgang Corcoran-Mathe
<first.lord.of.teal_AT_gmail.com> wrote:
> ---
> find.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/find.c b/find.c
> index dedf5a1..a870a90 100644
> --- a/find.c
> +++ b/find.c
> _AT_@ -429,6 +429,7 @@ pri_ok(struct arg *arg)
> /* insert filename everywhere user gave us {} */
> for (brace = o->braces; *brace; brace++)
> **brace = arg->path;
> + *brace = NULL;
>
> switch((pid = fork())) {
> case -1:
> --
> 2.3.5
>
>

Not needed there, *brace will already be NULL or the loop wouldn't
have stopped (the cause of the segfault). Needed in get_ok_arg() so
that it is NULL when we get here. See attached.

-emg

Received on Mon Jun 15 2015 - 22:51:00 CEST

This archive was generated by hypermail 2.3.0 : Thu Jun 18 2015 - 17:37:24 CEST