Quoth Evan Gates on Mon, Jun 15 2015 13:51 -0700:
> On Mon, Jun 15, 2015 at 12:27 PM, Wolfgang Corcoran-Mathe
> <first.lord.of.teal_AT_gmail.com> wrote:
>> ---
>> find.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/find.c b/find.c
>> index dedf5a1..a870a90 100644
>> --- a/find.c
>> +++ b/find.c
>> _AT_@ -429,6 +429,7 @@ pri_ok(struct arg *arg)
>> /* insert filename everywhere user gave us {} */
>> for (brace = o->braces; *brace; brace++)
>> **brace = arg->path;
>> + *brace = NULL;
>>
>> switch((pid = fork())) {
>> case -1:
>> --
>> 2.3.5
>>
>>
>
> Not needed there, *brace will already be NULL or the loop wouldn't
> have stopped (the cause of the segfault). Needed in get_ok_arg()
> so that it is NULL when we get here. See attached.
It occurred to me shortly after sending that patch that this should
have been in get_ok_arg(), as with get_exec_arg(). But without this
patch (or yours), I get a segfault when the end of the arg list is
reached. Your patch is obviously the right one, but I would like
to understand why both seem to have the same effect.
There is another semi-bug in -ok's input parsing. If the char read
into reply in pri_ok() at line 415 is a newline the user will have
to enter another newline to skip the file. This seems clumsy, but
it might be what you want.
Regards,
--
WCM
Received on Tue Jun 16 2015 - 00:48:29 CEST