Re: [hackers] [st][PATCH] Change mshortcuts to mkeys to make it clear

From: Pickfire <pickfire_AT_riseup.net>
Date: Sat, 31 Oct 2015 13:18:28 +0800

On Fri, Oct 30, 2015 at 10:07:44PM -0700, Eric Pruitt wrote:
>I don't understand this patch. Mice don't have keys, they have buttons
>(at least the dialects of English I'm familiar with). "Mouse keys" just
>sounds wrong and confusing to me.
>
>Eric

To see what it looks like before the patch s/mkeys/mshortcuts/
After the patch:


1. From st.c:

void
bpress(XEvent *e)
{
        struct timespec now;
                Mousekey *mk;
...
        for (mk = mkeys; mk < mkeys + LEN(mkeys); mk++) {

So I think it should be mkeys instead of mshortcuts because it uses
Mousekey.


2. From config.def.h:

static Shortcut shortcuts[] = {
        /* mask keysym function argument */
...
static Mousekey mkeys[] = {
        /* button mask string */
...
static Key key[] = {
        /* keysym mask string appkey appcursor crlf */

As the mkeys look similar to the key and it is different from shortcuts.


3. After you apply the patch st-git-20151006-scrollback-mouse.diff[0],
you will fell that it is a bit weird to use mshortcuts.

[0]: http://st.suckless.org/patches/st-git-20151006-scrollback-mouse.diff


That is what I have based on to make it clearer although I know that
mouse doesn't have keys.

-- 
 _____________________________________
< Do what you like, like what you do. >
 -------------------------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

Received on Sat Oct 31 2015 - 06:18:28 CET

This archive was generated by hypermail 2.3.0 : Sat Oct 31 2015 - 06:24:11 CET