Greetings.
On Sat, 31 Oct 2015 09:29:54 +0100 Pickfire <pickfire_AT_riseup.net> wrote:
> To see what it looks like before the patch s/mkeys/mshortcuts/
> After the patch:
>
>
> 1. From st.c:
>
> void
> bpress(XEvent *e)
> {
> struct timespec now;
> Mousekey *mk;
> ...
> for (mk = mkeys; mk < mkeys + LEN(mkeys); mk++) {
>
> So I think it should be mkeys instead of mshortcuts because it uses
> Mousekey.
>
>
> 2. From config.def.h:
>
> static Shortcut shortcuts[] = {
> /* mask keysym function argument */
> ...
> static Mousekey mkeys[] = {
> /* button mask string */
> ...
> static Key key[] = {
> /* keysym mask string appkey appcursor crlf */
>
> As the mkeys look similar to the key and it is different from shortcuts.
>
>
> 3. After you apply the patch st-git-20151006-scrollback-mouse.diff[0],
> you will fell that it is a bit weird to use mshortcuts.
I don’t want to comment this nonesense.
See the git log for how I increased the consistency.
Sincerely,
Christoph Lohmann
Received on Sat Oct 31 2015 - 09:29:54 CET