[hackers] [surf] Be more specific about what enablestyles parameter does.

From: Quentin Rameau <quinq+hackers_AT_fifth.space>
Date: Tue, 3 Nov 2015 16:50:21 +0100

The enablestyles configuration variable and parameter flag manages the
global application of styles, not just the site-specific styles.

---
 config.def.h |  2 +-
 surf.1       |  4 ++--
 surf.c       | 14 +++++++-------
 3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/config.def.h b/config.def.h
index 368291f..1c18827 100644
--- a/config.def.h
+++ b/config.def.h
_AT_@ -30,7 +30,7 @@ static int diskcachebytes         = 5 * 1024 * 1024;
 static Bool enableplugins         = TRUE;
 static Bool enablescripts         = TRUE;
 static Bool enableinspector       = TRUE;
-static Bool enablestyles          = TRUE;
+static Bool enablestyle           = TRUE;
 static Bool loadimages            = TRUE;
 static Bool hidebackground        = FALSE;
 static Bool allowgeolocation      = TRUE;
diff --git a/surf.1 b/surf.1
index 3457a55..867783d 100644
--- a/surf.1
+++ b/surf.1
_AT_@ -75,10 +75,10 @@ Disable kiosk mode (disable key strokes and right click)
 Enable kiosk mode (disable key strokes and right click)
 .TP
 .B \-m
-Disable the site-specific styles.
+Disable application of user style sheets.
 .TP
 .B \-M
-Enable the site-specific styles.
+Enable application of user style sheets.
 .TP
 .B \-n
 Disable the Web Inspector (Developer Tools).
diff --git a/surf.c b/surf.c
index dd9c306..586bde1 100644
--- a/surf.c
+++ b/surf.c
_AT_@ -803,7 +803,7 @@ loadstatuschange(WebKitWebView *view, GParamSpec *pspec, Client *c)
 		}
 		setatom(c, AtomUri, uri);
 
-		if (enablestyles)
+		if (enablestyle)
 			setstyle(c, getstyle(uri));
 		break;
 	case WEBKIT_LOAD_FINISHED:
_AT_@ -1021,7 +1021,7 @@ newclient(void)
 	             "default-font-size", defaultfontsize, NULL);
 	g_object_set(G_OBJECT(settings),
 	             "resizable-text-areas", 1, NULL);
-	if (enablestyles)
+	if (enablestyle)
 		setstyle(c, getstyle("about:blank"));
 
 	/*
_AT_@ -1534,8 +1534,8 @@ togglescrollbars(Client *c, const Arg *arg)
 void
 togglestyle(Client *c, const Arg *arg)
 {
-	enablestyles = !enablestyles;
-	setstyle(c, enablestyles ? getstyle(geturi(c)) : "");
+	enablestyle = !enablestyle;
+	setstyle(c, enablestyle ? getstyle(geturi(c)) : "");
 
 	updatetitle(c);
 }
_AT_@ -1566,7 +1566,7 @@ gettogglestat(Client *c)
 	g_object_get(G_OBJECT(settings), "enable-plugins", &value, NULL);
 	togglestat[p++] = value? 'V': 'v';
 
-	togglestat[p++] = enablestyles ? 'M': 'm';
+	togglestat[p++] = enablestyle ? 'M': 'm';
 
 	togglestat[p] = '\0';
 }
_AT_@ -1709,10 +1709,10 @@ main(int argc, char *argv[])
 		kioskmode = 1;
 		break;
 	case 'm':
-		enablestyles = 0;
+		enablestyle = 0;
 		break;
 	case 'M':
-		enablestyles = 1;
+		enablestyle = 1;
 		break;
 	case 'n':
 		enableinspector = 0;
-- 
2.6.2

Received on Tue Nov 03 2015 - 16:50:21 CET