[hackers] [sent] drw.c: Avoid potential memory leak in drw_cur_create()

From: Quentin Rameau <quinq+hackers_AT_fifth.space>
Date: Wed, 18 Nov 2015 22:45:26 +0100

If drw was NULL, memory was still allocated for cur.

---
 drw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drw.c b/drw.c
index a2dfe6c..15797ce 100644
--- a/drw.c
+++ b/drw.c
_AT_@ -396,9 +396,9 @@ drw_font_getexts(Fnt *font, const char *text, unsigned int len, unsigned int *w,
 
 Cur *
 drw_cur_create(Drw *drw, int shape) {
-	Cur *cur = (Cur *)calloc(1, sizeof(Cur));
+	Cur *cur;
 
-	if(!drw || !cur)
+	if(!drw || !(cur = (Cur *)calloc(1, sizeof(Cur))))
 		return NULL;
 	cur->cursor = XCreateFontCursor(drw->dpy, shape);
 	return cur;
-- 
2.6.2

Received on Wed Nov 18 2015 - 22:45:26 CET