Re: [hackers] [PATCH] [sent] Quick patch to replace png with farbfeld

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Tue, 8 Dec 2015 22:31:31 +0100

FRIGN wrote:
> Dimitris Papastamos <sin_AT_2f30.org> wrote:
> > This also works with jpg and gif and others. The 2ff wrapper will use
> > imagemagick conversion tools. This is temporary as jpg2ff and gif2ff will
> > also be implemented.
>
> As a side note, the 2ff-filter can also receive png-images and already
> automatically call png2ff when it detects a png. If you look at the 2ff
> script, you'll notice how simple it is really.

Heyho,

as you guys can see from the push hook mails, I just merged the second farbfeld
patch from Dimitris. Since case-switching in sent (the filters array) and in 2ff
again seems kind of redundant, I would remove the filter array and regex code
again and just call filter() on the 2ff script. Of course this only works, if
2ff does not go „full pipeline“ and continues to support handling one argument.

I also noticed you used `/ 257` to convert from uint16_t to uint8_t, which I
fixed in the transparency patch to be `/ 256`.

Another change I want to make is combining the open and read function. Then we
would know if every image could be loaded correctly before even starting the
presentation, which prevents erroring out right in the middle of your talk, when
some image could not be loaded from advance().

I also pushed an update to sent/index.md in the wiki describing the new
situation.

--Markus
Received on Tue Dec 08 2015 - 22:31:31 CET