Re: [hackers] [dmenu][RFC][PATCH] History functionality

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Wed, 9 Dec 2015 11:16:07 +0100

On Wed, Dec 9, 2015 at 11:12 AM, Roberto E. Vargas Caballero
<k0ga_AT_shike2.com> wrote:
> On Wed, Dec 09, 2015 at 10:31:09AM +0100, Silvan Jegen wrote:
>> I realized that I am not dealing with the case that the history file
>> does not exist already. I added a simple check for that (although I
>> was considering just putting in a comment saying that it has to).
>>
>
>> +if [ ! -e $historyfile ]; then
>> + touch $historyfile
>> +fi
>
> Why the if?, why not directly touch the file?

You are right. I confused the history file with the cache file. The
cache file's time stamp is compared to the directories in the PATH to
determine if it has to be updated or not.

Removing the if is even simpler.
Received on Wed Dec 09 2015 - 11:16:07 CET