Re: [hackers] [st] A better XClassHint class definition

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Sun, 20 Dec 2015 01:44:08 +0100

Greetings.

On Sun, 20 Dec 2015 01:44:08 +0100 Ammar James <ammar.james_AT_alumni.stonybrook.edu> wrote:
> One problem with st is that it incorrectly assigns the WM_CLASS when
> running st with the "-c" flag. So, for example, we are unable right now
> to launch the following script from dmenu and have the new terminal
> launch with the appropriate tag as defined in dwm's config.h:

Thanks for sending this in, I’ve applied your patch.

> Please see the patch below to correct this behavior:
> --- st.c 2015-12-19 18:41:09.211014836 +0000
> +++ st-modified.c 2015-12-19 18:38:34.832011313 +0000
> _AT_@ -2987,7 +2987,7 @@
>
> void
> xhints(void) {
> - XClassHint class = {opt_class ? opt_class : termname, termname};
> + XClassHint class = {termname, opt_class ? opt_class : termname};
> XWMHints wm = {.flags = InputHint, .input = 1};
> XSizeHints *sizeh = NULL;

On IRC I’ve given you hints how to make it more easier to apply patches
from e‐mails.


Sincerely,

Christoph Lohmann

💻 http://r-36.net
💻 gopher://r-36.net
http://r-36.net/about
🔐 1C3B 7E6F 9805 E5C8 C0BD 1F7F EA21 7AAC 09A9 CB55
🔐 http://r-36.net/about/20h.asc
📧 20h_AT_r-36.net
Received on Sun Dec 20 2015 - 01:44:08 CET

This archive was generated by hypermail 2.3.0 : Sun Dec 20 2015 - 02:00:15 CET