I agree this is a bit of a mess. The current code assumes that:
LINEWISE == VIS_MOTIONTYPE_LINEWISE &&
CHARWISE == VIS_MOTIONTYPE_CHARWISE
and that the values are distinct from the other flags.
However your patch is the wrong way around. The idea was to only
expose the the char / linewise properties in the public API as
the other flags are implementation details.
An improvement would probably be to initialize LINEWISE and CHARWISE
in vis-core.h with the constants from vis.h.
--
Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: 10C93617
Received on Sun Dec 20 2015 - 12:12:08 CET