[hackers] [st] Ok, no need for a separate version function. || Christoph Lohmann

From: <git_AT_suckless.org>
Date: Sat, 30 Jan 2016 09:50:51 +0100 (CET)

commit 82335583eba15e87749d0e663270353005fca30b
Author: Christoph Lohmann <20h_AT_r-36.net>
AuthorDate: Sat Jan 30 09:50:18 2016 +0100
Commit: Christoph Lohmann <20h_AT_r-36.net>
CommitDate: Sat Jan 30 09:50:18 2016 +0100

    Ok, no need for a separate version function.
    
    This is just redundant metadata. Please add Java comment meta classes too.

diff --git a/st.c b/st.c
index 38abffb..005bf1d 100644
--- a/st.c
+++ b/st.c
_AT_@ -486,7 +486,6 @@ static void *xrealloc(void *, size_t);
 static char *xstrdup(char *);
 
 static void usage(void);
-static void version(void);
 
 static void (*handler[LASTEvent])(XEvent *) = {
         [KeyPress] = kpress,
_AT_@ -4342,12 +4341,6 @@ usage(void)
         " [stty_args ...]\n", argv0, argv0);
 }
 
-void
-version(void)
-{
- die("%s " VERSION " (c) 2010-2016 st engineers\n", argv0);
-}
-
 int
 main(int argc, char *argv[])
 {
_AT_@ -4395,7 +4388,7 @@ main(int argc, char *argv[])
                 opt_embed = EARGF(usage());
                 break;
         case 'v':
- version();
+ die("%s " VERSION " (c) 2010-2016 st engineers\n", argv0);
                 break;
         default:
                 usage();
Received on Sat Jan 30 2016 - 09:50:51 CET