Re: [hackers] [patch] st crash inside getsel

From: David Phillips <dbphillipsnz_AT_gmail.com>
Date: Tue, 19 Apr 2016 14:24:17 +1200

On Tue, Apr 19, 2016 at 02:48:14AM +0100, rain1_AT_openmailbox.org wrote:
> Hello
>
> I had been noticing st 0.6 terminals sometimes disappearing on openbsd. I
> managed to reproduce the crash quite consistently by trying to select and
> copy the output of: man ls | head -10.
>
> Debugged the coredump and saw that linelen is always zero before the crash -
> in which case I think there is an underflow in this line: last =
> &term.line[y][MIN(lastx, linelen-1)]; that was resulting in memory
> corruption which caused the subsequent last->mode to segment fault.
>
Hi,

Looks like k0ga fixed this in commit 5d2d9d54, in September last year.

Thanks

Received on Tue Apr 19 2016 - 04:24:17 CEST

This archive was generated by hypermail 2.3.0 : Tue Apr 19 2016 - 04:36:25 CEST