Re: [hackers] [patch] st crash inside getsel

From: <rain1_AT_openmailbox.org>
Date: Tue, 19 Apr 2016 12:08:50 +0100

On 2016-04-19 03:24, David Phillips wrote:
> On Tue, Apr 19, 2016 at 02:48:14AM +0100, rain1_AT_openmailbox.org wrote:
>> Hello
>>
>> I had been noticing st 0.6 terminals sometimes disappearing on
>> openbsd. I
>> managed to reproduce the crash quite consistently by trying to select
>> and
>> copy the output of: man ls | head -10.
>>
>> Debugged the coredump and saw that linelen is always zero before the
>> crash -
>> in which case I think there is an underflow in this line: last =
>> &term.line[y][MIN(lastx, linelen-1)]; that was resulting in memory
>> corruption which caused the subsequent last->mode to segment fault.
>>
> Hi,
>
> Looks like k0ga fixed this in commit 5d2d9d54, in September last year.
>
> Thanks

Apologies for the noise. I was using release, not git. Will update
everything now.
Received on Tue Apr 19 2016 - 13:08:50 CEST