Re: [hackers] [sbase] [PATCH 0/6] Various bug fixes

From: Michael Forney <mforney_AT_mforney.org>
Date: Fri, 8 Jul 2016 18:52:01 -0700

On 5/17/16, Marc Collin <marc.collin7_AT_gmail.com> wrote:
>>I think sbase
>>could use some sort of test suite so we could check for correct
>>behavior and accidental regressions.
>
> There's base-util-tests by maandree.
> https://github.com/maandree/base-util-tests

Oh neat, I wasn't aware of that.

Unfortunately it looks like all of those tests require bash. Maybe
I'll be able to find some time to port to POSIX sh or rc, and then I
can contribute some of the test cases I put in the commit
descriptions.

> On Sat, May 14, 2016 at 10:56 PM, Michael Forney <mforney_AT_mforney.org>
> wrote:
>> Michael Forney (6):
>> Revert "Fix showing directories when -R flag is set in ls(1)"
>> Revert "ls: only display directory headers when more than one
>> directory is specified"
>> ls: Don't show directory name with single directory operand
>> ls: Simplify some logic
>> sort: Fix line comparison when col buffer contains data from longer
>> line
>> linecmp: Handle NUL bytes properly
>>
>> libutil/linecmp.c | 11 ++---------
>> ls.c | 23 ++++++++++++-----------
>> sort.c | 37 ++++++++++++++++++++-----------------
>> 3 files changed, 34 insertions(+), 37 deletions(-)

Ping on these patches. I've been running with these commits for almost
two months now and haven't noticed any regressions.

-- 
Michael Forney <mforney_AT_mforney.org>
Received on Sat Jul 09 2016 - 03:52:01 CEST

This archive was generated by hypermail 2.3.0 : Sat Jul 09 2016 - 04:01:32 CEST