Re: [hackers] [dwm][PATCH] fix lost focus issues when current window is fullscreen

From: Sören Tempel <soeren_AT_soeren-tempel.net>
Date: Wed, 27 Jul 2016 12:43:05 +0200

On 26.07.16, Hiltjo Posthuma wrote:
> I don't think we should reset fullscreen on the current client, but instead
> keep the focus on it and don't change focus to a new client while a fullscreen
> one is running.

I didn't have time to test your patch yet, but if I understood you
correctly here is how I found that bug originally and why I think that
your suggestion is somewhat counter intuitiv:

I sometimes run my terminal emulator in fullscreen mode and every now
and then I decrypt a gpg file from that terminal emulator. Since I use
gpg-agent a pinentry gtk window is spawned if I didn't enter my
passphrase so far with your patch I wouldn't notice that the window
spawned at all. With my patch the pinentry window would be focused, I
could enter the passphrase and make my terminal emulator window
fullscreen again afterwards which is imho more intuitiv.

I will none the less test your patch as soon as I return home from work
today just take this into consideration for now.

Sören.
Received on Wed Jul 27 2016 - 12:43:05 CEST