Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

From: Greg Reagle <greg.reagle_AT_umbc.edu>
Date: Fri, 07 Oct 2016 10:13:00 -0400

On Fri, Oct 7, 2016, at 09:43, Laslo Hunhold wrote:
> one thing that has caught my attention is the titling of the patches.
> It is better to use the active form rather than passive form, so my
> suggestions for renaming would be
>
> "ed: newly joined lines are placed correctly"
> -> "ed: place newly joined lines correctly"
>
> "ed: wrote manpage"
> -> "add a manpage"

These are both active. "wrote" is the past tense and "add" is not, but
neither are passive.
Received on Fri Oct 07 2016 - 16:13:00 CEST