Re: [hackers] [sbase] [patch] cp: add -i flag

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Sun, 9 Oct 2016 14:37:14 +0200

Two things I noticed:

It does not seem to compile, it requires cp_iflag in fs.h:

diff --git a/fs.h b/fs.h
index 15ae5f4..36b9cb3 100644
--- a/fs.h
+++ b/fs.h
_AT_@ -25,6 +25,7 @@ enum {
 
 extern int cp_aflag;
 extern int cp_fflag;
+extern int cp_iflag;
 extern int cp_pflag;
 extern int cp_rflag;
 extern int cp_vflag;



Another one: when return is pressed it seems to be processed as affirmative
and overwrite the file. It should only overwrite if 'y' is entered.

-- 
Kind regards,
Hiltjo
Received on Sun Oct 09 2016 - 14:37:14 CEST

This archive was generated by hypermail 2.3.0 : Sun Oct 09 2016 - 14:48:15 CEST