Re: [hackers] [sbase] [PATCH] xinstall: Fix broken memmove with -t

From: Laslo Hunhold <>
Date: Tue, 27 Dec 2016 13:45:35 +0100

On Thu, 1 Dec 2016 22:50:20 -0800
Michael Forney <> wrote:

Hey Michael,

> memmove moves a number of bytes, not pointers, so if you passed a
> number of arguments that is larger than the pointer byte size, you
> could end up crashing or skipping the install of a file and
> installing another twice.
> Also, argv was never decreased to match the moved arguments, so the -t
> parameter was added in the NULL argv slot.

after taking another look at this patch, it totally makes sense. Thanks
for your submission! I applied it, but need to note here that this is a
pretty hacky contraption. :P



Laslo Hunhold <>
Received on Tue Dec 27 2016 - 13:45:35 CET

This archive was generated by hypermail 2.3.0 : Tue Dec 27 2016 - 15:15:36 CET