Re: [hackers] [dwm] [PATCH 2/3] Button passthrough when client is not focused

From: Anselm R Garbe <garbeam_AT_gmail.com>
Date: Mon, 27 Mar 2017 22:10:40 +0200

On 10 January 2017 at 18:56, Markus Teich <markus.teich_AT_stusta.mhn.de> wrote:
> Disclaimer: This patch is a bit of a grey area for my understanding of the
> grabbing mechanics. While preparing the user-patch for unsloppy focusing I
> noticed this bit from Erics patch is used to fix a bug which is also present in
> vanilla dwm. It's a little improbable to hit this bug in vanilla dwm, which is
> why it probably hasn't been discovered previously. So I just took the bug-fix
> part from Erics patch, applied it to vanilla dwm, also tested it for a while and
> it worked as I intend it to. However I would be very thankful if someone with
> more knowledge of the grabbing semantics could explain why exactly the bug
> occurs before this patch, why the changes in this patch fix that behavior and
> ultimately approve this patch for merging.

I don't remember the actual reason out of my head, but do remember
that we already had a very similar grabbing semantic in place until
around dwm 4.7. The reason for the bug seems to be a side-effect of
all the code optimisations since then.

-Anselm
Received on Mon Mar 27 2017 - 22:10:40 CEST