[hackers] [sbase] libutil: fix leaks || Hiltjo Posthuma

From: <git_AT_suckless.org>
Date: Sat, 13 May 2017 12:55:18 +0200 (CEST)

commit af392d1a764d7420c7b05bb9e13d7766a5979894
Author: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
AuthorDate: Sun May 7 13:50:26 2017 +0200
Commit: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
CommitDate: Sun May 7 13:50:26 2017 +0200

    libutil: fix leaks

diff --git a/libutil/cp.c b/libutil/cp.c
index 9bb517a..a8db0a2 100644
--- a/libutil/cp.c
+++ b/libutil/cp.c
_AT_@ -79,6 +79,7 @@ cp(const char *s1, const char *s2, int depth)
                 if (mkdir(s2, st.st_mode) < 0 && errno != EEXIST) {
                         weprintf("mkdir %s:", s2);
                         cp_status = 1;
+ closedir(dp);
                         return 0;
                 }
 
_AT_@ -122,15 +123,18 @@ cp(const char *s1, const char *s2, int depth)
                                 if (unlink(s2) < 0 && errno != ENOENT) {
                                         weprintf("unlink %s:", s2);
                                         cp_status = 1;
+ fclose(f1);
                                         return 0;
                                 } else if (!(f2 = fopen(s2, "w"))) {
                                         weprintf("fopen %s:", s2);
                                         cp_status = 1;
+ fclose(f1);
                                         return 0;
                                 }
                         } else {
                                 weprintf("fopen %s:", s2);
                                 cp_status = 1;
+ fclose(f1);
                                 return 0;
                         }
                 }
Received on Sat May 13 2017 - 12:55:18 CEST