Re: [hackers] [PATCH] Honor SURF_USERAGENT evironment variable

From: Vasily Kolobkov <polezaivsani_AT_openmailbox.org>
Date: Sat, 13 May 2017 13:17:25 +0200

[2017-05-13 12:48] Quentin Rameau <quinq_AT_fifth.space>
> > From: Vasily Kolobkov <>
>
> Hi Vasily,
>
> > +
> > + if ((envuseragent = getenv("SURF_USERAGENT")))
> > + fulluseragent = envuseragent;
>
> There is already a flag for this (surf -u "$SURF_USERAGENT"), could you
> explain why you need this?

Hey Quentin!

I've been using that to set a global custom user agent since
surf-webkit1. Thinking about it, doing it via fulluseragent in
config.h will suit me just as fine.

If nobody's using the SURF_USERAGENT (which seem to be the case :),
i'd rip it out and will submit a man patch (which still mentions
this env var) instead.

p.s. Does anyone know why surf's SIGCHLD handler reinstalls itself
on every invocation? And wouldn't ignoring it with SA_NOCLDSTOP |
SA_NOCLDWAIT flags set make a better option?

Cheers, V
Received on Sat May 13 2017 - 13:17:25 CEST