Re: [hackers] [st] Refactoring (-61 lines)

From: Hiltjo Posthuma <>
Date: Sun, 1 Oct 2017 14:16:26 +0200

On Sun, Sep 24, 2017 at 04:11:22PM -0500, Devin J. Pohly wrote:
> Some refactoring on the st codebase, reducing it by 61 lines and
> establishing cleaner separation between st.c and x.c. There are 28
> fewer extern variables, and <X11/*> and X-specific types are now
> included only in x.c.
> These commits move code between st.c and x.c, adjusting the
> linkage/storage modifiers or headers as needed.
> Notable change is patch 17/23, which migrates the config.h include from
> st.c to x.c, since most of the configuration variables were only used
> there.


Thanks for the patches. It seems to be well-written and fortunately not
add too much abstractions.

I have a few notes:

Regarding the patch: [st][PATCH 05/23] Move ISO 14755 handling into x.c
This does not seem X11-specific to me, can this be added/stay in st.c? Why
was this separated?

In addition I think the fontconfig include can be (re)moved from st.c also
        #include <fontconfig/fontconfig.h>

Kind regards,
Received on Sun Oct 01 2017 - 14:16:26 CEST

This archive was generated by hypermail 2.3.0 : Sun Oct 01 2017 - 14:24:22 CEST