Re: [hackers] [sent] [PATCH] Add toggle fullscreen shortcut: f

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Mon, 19 Mar 2018 13:55:04 +0000

On Mon, Mar 19, 2018 at 09:20:35AM -0300, Héctor Monacci wrote:
> 2018-03-18 17:47 GMT-03:00 Laslo Hunhold <dev_AT_frign.de>:
> > Hey Héctor,
> >
> >> Hi people, this is my first one, so please be patient if I
> >> inadvertently break rules.
> >>
> >> After talking to Markus Teich, I added a fullscreen toggle function to
> >> sent. It uses the f key for toggling.
> >
> > it looks good, but I don't really like the idea of putting things into
> > a program which are actually the window manager's job.
> > Is it really our fault that the popular window managers do not support
> > fullscreening an arbitrary window?
>
> Hi Laslo!
>
> No, of course it is not our fault... Nevertheless, I think even users
> of dwm would find it easier to just touch the f key and have
> fullscreen toggle on and off.
>
> Look, my desktop/wm is XFCE, and by pressing Alt-F11 I get fullscreen
> on and off everywhere. But mnemonics and lazyness push me once and
> again to try the f key. It's just simpler, it's just less effort.
>
> The code overhead for adding this to "sent", both in source and in the
> executable, is absolutely minimal.
>
> I still think this change would make "sent" a bit better.
>
> Don't you think it's worth it?

Sounds good to me.
Received on Mon Mar 19 2018 - 14:55:04 CET